Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

string_decoder: throw an error when writing a too long buffer #52215

Closed
wants to merge 1 commit into from
Closed

string_decoder: throw an error when writing a too long buffer #52215

wants to merge 1 commit into from

Conversation

kylo5aby
Copy link
Contributor

Fixes: #52214

@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Mar 26, 2024
@mertcanaltin mertcanaltin added the string_decoder Issues and PRs related to the string_decoder subsystem. label Mar 26, 2024
@theanarkh theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 27, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 27, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57966/

@theanarkh
Copy link
Contributor

The test will fail on some platforms. It looks like 2**31 is too big.

13:29:07 not ok 947 pummel/test-string-decoder-large-buffer
13:29:07   ---
13:29:07   duration_ms: 231.98500
13:29:07   severity: fail
13:29:07   exitcode: 1
13:29:07   stack: |-
13:29:07     C:\workspace\node-test-binary-windows-js-suites\node\test\pummel\test-string-decoder-large-buffer.js:24
13:29:07         throw e;
13:29:07         ^
13:29:07     
13:29:07     RangeError [ERR_OUT_OF_RANGE]: The value of "size" is out of range. It must be >= 0 && <= 2147483647. Received 2147483648
13:29:07         at Function.alloc (node:buffer:389:3)
13:29:07         at Object.<anonymous> (C:\workspace\node-test-binary-windows-js-suites\node\test\pummel\test-string-decoder-large-buffer.js:18:22)
13:29:07         at Module._compile (node:internal/modules/cjs/loader:1421:14)
13:29:07         at Module._extensions..js (node:internal/modules/cjs/loader:1499:10)
13:29:07         at Module.load (node:internal/modules/cjs/loader:1232:32)
13:29:07         at Module._load (node:internal/modules/cjs/loader:1048:12)
13:29:07         at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:187:14)
13:29:07         at node:internal/main/run_main_module:28:49 {
13:29:07       code: 'ERR_OUT_OF_RANGE'
13:29:07     }
13:29:07

@kylo5aby kylo5aby force-pushed the string_decoder branch 3 times, most recently from f691105 to dbb31b1 Compare March 27, 2024 13:39
@kylo5aby
Copy link
Contributor Author

kylo5aby commented Mar 27, 2024 •
edited
Loading

The test will fail on some platforms. It looks like 2**31 is too big.

13:29:07 not ok 947 pummel/test-string-decoder-large-buffer
13:29:07   ---
13:29:07   duration_ms: 231.98500
13:29:07   severity: fail
13:29:07   exitcode: 1
13:29:07   stack: |-
13:29:07     C:\workspace\node-test-binary-windows-js-suites\node\test\pummel\test-string-decoder-large-buffer.js:24
13:29:07         throw e;
13:29:07         ^
13:29:07     
13:29:07     RangeError [ERR_OUT_OF_RANGE]: The value of "size" is out of range. It must be >= 0 && <= 2147483647. Received 2147483648
13:29:07         at Function.alloc (node:buffer:389:3)
13:29:07         at Object.<anonymous> (C:\workspace\node-test-binary-windows-js-suites\node\test\pummel\test-string-decoder-large-buffer.js:18:22)
13:29:07         at Module._compile (node:internal/modules/cjs/loader:1421:14)
13:29:07         at Module._extensions..js (node:internal/modules/cjs/loader:1499:10)
13:29:07         at Module.load (node:internal/modules/cjs/loader:1232:32)
13:29:07         at Module._load (node:internal/modules/cjs/loader:1048:12)
13:29:07         at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:187:14)
13:29:07         at node:internal/main/run_main_module:28:49 {
13:29:07       code: 'ERR_OUT_OF_RANGE'
13:29:07     }
13:29:07

I believe it's because of the buffer with size > INT32_MAX on x32 platform which will throw range error, I have updated and skip the test file on x32 platform

@kylo5aby
Copy link
Contributor Author

@theanarkh Could you pls retrigger CI?

@theanarkh theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 24, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 24, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58651/

@theanarkh theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 24, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 24, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58673/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58689/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58749/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 4, 2024 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/58916/ 💛

jasnell pushed a commit that referenced this pull request May 4, 2024
@kylo5aby @jasnell
string_decoder: throw an error when writing a too long buffer
8123be1 
PR-URL: #52215
Fixes: #52214
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: theanarkh <theratliter@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented May 4, 2024

Landed in 8123be1

@jasnell jasnell closed this May 4, 2024
Ch3nYuY pushed a commit to Ch3nYuY/node that referenced this pull request May 8, 2024
@kylo5aby @Ch3nYuY
string_decoder: throw an error when writing a too long buffer
9d85ac1 
PR-URL: nodejs#52215
Fixes: nodejs#52214
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: theanarkh <theratliter@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request May 8, 2024
@kylo5aby @targos
string_decoder: throw an error when writing a too long buffer
b0e6a6b 
PR-URL: #52215
Fixes: #52214
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: theanarkh <theratliter@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request May 13, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@kylo5aby @marco-ippolito
string_decoder: throw an error when writing a too long buffer
a5f3dd1 
PR-URL: #52215
Fixes: #52214
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: theanarkh <theratliter@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@marco-ippolito marco-ippolito mentioned this pull request Jun 17, 2024
Merged
eliphazbouye pushed a commit to eliphazbouye/node that referenced this pull request Jun 20, 2024
@kylo5aby @eliphazbouye
string_decoder: throw an error when writing a too long buffer
3b3676d 
PR-URL: nodejs#52215
Fixes: nodejs#52214
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: theanarkh <theratliter@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
@kylo5aby @bmeck
string_decoder: throw an error when writing a too long buffer
ab8126f 
PR-URL: nodejs#52215
Fixes: nodejs#52214
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: theanarkh <theratliter@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theanarkh theanarkh theanarkh approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. string_decoder Issues and PRs related to the string_decoder subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

StringDecoder.write() doesn't report error when buffer length exceeds max integer value
7 participants
@kylo5aby @nodejs-github-bot @theanarkh @jasnell @addaleax @lpinca @mertcanaltin